Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smart-slippage): fix smart slip tooltip and feature flag #5004

Merged
merged 5 commits into from
Oct 17, 2024
Merged

fix(smart-slippage): fix smart slip tooltip and feature flag #5004

merged 5 commits into from
Oct 17, 2024

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Oct 17, 2024 •
edited by elena-zh
Loading

Summary

Fixes #5001

Show non-dynamic slippage tooltips when feature flag is off.
This also helped me identify an issue with the feature flag that was essentially never turning off.

To Test

  1. With the flag on, check the tooltips
  • Should be the dynamic version
  1. With the flag off (set to 0 OR having lauchdarkly requests blocked), check the tooltips
  • Should be the non-dynamic version
  • There should be no suggested slippage

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:26pm
cowfi ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:26pm
explorer-dev ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:26pm
swap-dev ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:26pm
widget-configurator ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:26pm

@alfetopito alfetopito self-assigned this Oct 17, 2024
@alfetopito alfetopito requested review from a team October 17, 2024 13:47
elena-zh
elena-zh approved these changes Oct 17, 2024
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alfetopito alfetopito merged commit c6ea5af into release/17-10-2024 Oct 17, 2024
11 of 12 checks passed
@alfetopito alfetopito deleted the fix/5001_smart-slip-tooltip branch October 17, 2024 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @shoom3301 @elena-zh